<html>
<head><meta charset="utf-8"><title>android change #74860 · t-compiler · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/index.html">t-compiler</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/android.20change.20.2374860.html">android change #74860</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="205371045"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/android%20change%20%2374860/near/205371045" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/android.20change.20.2374860.html#205371045">(Jul 29 2020 at 15:17)</a>:</h4>
<p>Hey all, so <code>jmgao</code> proposed a change to the android libstd that uses some internal android mechanisms to validate file descriptions are used correctly. They outline that it is somewhat of a breaking change for certain constructs, such as <code>File::from_raw_fd(22).into_raw_fd()</code>. I'm inclined to land it with the relnotes tag, but I'm not sure the proper process here. (It'd be nice if we had a notification group for the android target  I suppose)</p>



<a name="205371097"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/android%20change%20%2374860/near/205371097" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/android.20change.20.2374860.html#205371097">(Jul 29 2020 at 15:18)</a>:</h4>
<p>cc <span class="user-mention" data-user-id="116083">@pnkfelix</span></p>



<a name="205371277"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/android%20change%20%2374860/near/205371277" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/android.20change.20.2374860.html#205371277">(Jul 29 2020 at 15:19)</a>:</h4>
<p>An MCP may be the appropriate decision point here, or even FCP since this is a user-visible change.</p>



<a name="205372011"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/android%20change%20%2374860/near/205372011" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> mati865 <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/android.20change.20.2374860.html#205372011">(Jul 29 2020 at 15:25)</a>:</h4>
<p>Doesn't it require T-libs approval?</p>



<a name="205373360"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/android%20change%20%2374860/near/205373360" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/android.20change.20.2374860.html#205373360">(Jul 29 2020 at 15:35)</a>:</h4>
<p>It's a good idea to bring libs into it, yeah</p>



<a name="205373516"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/android%20change%20%2374860/near/205373516" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> nikomatsakis <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/android.20change.20.2374860.html#205373516">(Jul 29 2020 at 15:36)</a>:</h4>
<p>Pinged them and tagged as T-libs.</p>



<a name="205414266"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/android%20change%20%2374860/near/205414266" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/android.20change.20.2374860.html#205414266">(Jul 29 2020 at 21:11)</a>:</h4>
<p>this issue was nominated and labelled with <code>T-libs</code> and <code>T-compiler</code>, checked with <span class="user-mention silent" data-user-id="116009">nikomatsakis</span> to see if we want it for this <code>T-compiler</code> weekly meeting and it seems like we don't for now</p>



<a name="205414312"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/android%20change%20%2374860/near/205414312" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Santiago Pastorino <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/android.20change.20.2374860.html#205414312">(Jul 29 2020 at 21:12)</a>:</h4>
<p>cc <span class="user-mention" data-user-id="116083">@pnkfelix</span> just in case you wonder why is not included in the agenda :)</p>



<a name="205671945"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/android%20change%20%2374860/near/205671945" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/android.20change.20.2374860.html#205671945">(Aug 01 2020 at 08:44)</a>:</h4>
<p>I'm not an expert on Android, but I do have some knowledge.</p>



<a name="205671958"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/android%20change%20%2374860/near/205671958" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Josh Triplett <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/android.20change.20.2374860.html#205671958">(Aug 01 2020 at 08:44)</a>:</h4>
<p>I would like to take a look at the change. This doesn't sound like something we should be doing.</p>



<a name="206148535"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/131828-t-compiler/topic/android%20change%20%2374860/near/206148535" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/131828-t-compiler/topic/android.20change.20.2374860.html#206148535">(Aug 06 2020 at 14:29)</a>:</h4>
<p><span class="user-mention" data-user-id="239881">@Josh Triplett</span> Probably best to comment on the PR itself, <a href="https://github.com/rust-lang/rust/pull/74860">https://github.com/rust-lang/rust/pull/74860</a></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>